Upgrade knex version - Githubissues

rmp135 / sql-ts

Generate TypeScript interfaces from a SQL database.

MIT License

466 stars 64 forks source link

Upgrade knex version #120

Closed filenwind closed 1 year ago

filenwind commented 1 year ago

Knex currently is 2.3.0

But sql-ts using ^1.0.3

Which cause the typing wrong when I put the knex instance to param

Type 'import("{projectRoot}/node_modules/knex/types/index").Knex.Value' is not assignable to type 'import("{projectRoot}/node_modules/@rmp135/sql-ts/node_modules/knex/types/index").Knex.Value'.

Or set knex as peer dependency?

Thanks!

rmp135 commented 1 year ago

Merged #114 which should fix this issue.