search

rmpestano / cukedoctor

BDD living documentation using Cucumber and Asciidoctor: https://goo.gl/Yp3NiU
https://rmpestano.github.io/cukedoctor/
Apache License 2.0
122 stars 23 forks source link

fix(i18n): allow for single quotes to be used in features titles #254

Closed rdlopes closed 2 years ago

rdlopes commented 2 years ago

I'm a French user of Cukedoctor and I have noticed that I cannot use single quotes in the feature's title. This PR fixes the single quote problem by replacing single quotes with "-" (dash) characters.

rdlopes commented 2 years ago

I could have used pass-throughs in asciidoc format but this fix makes it lighter change.

rdlopes commented 2 years ago

There's something weird about using maven-plugin-api in version 2.0 and declaring provided 3.3.3. Since it's used for test, I added the scope test for the hard dependency

rdlopes commented 2 years ago

Which json output should I use for testing ?

rmpestano commented 2 years ago

Thank you @rdlopes! I'll release this fix in 3.8.0 over the weekend. Cheers!