search

rmpestano / cukedoctor

BDD living documentation using Cucumber and Asciidoctor: https://goo.gl/Yp3NiU
https://rmpestano.github.io/cukedoctor/
Apache License 2.0
122 stars 23 forks source link

Set the language with a tag @language-<language> #261

Closed rdlopes closed 2 years ago

rdlopes commented 2 years ago

Hi Raphaël, since I'm using Cucumber 7, I have been facing the disappearance of the language feature.

This, because Cucumber decided to stop supporting comments in JSON files. So now, language comments are not anymore properly set in JSON features and the i18n is not working.

This change aims at adding a tag @language-(en|es|fr|ge|pt), to mimic the behavior or ordering and allow users to update their Cucumber version.

rdlopes commented 2 years ago

I had lots of warnings regarding code prior to Java 8. I applied boyscout rule for cleaning code as much as I could.

I didn't touch on one particular type of errors: null check. IDE was complaining that some inputs/variables could be null or throw NullPointerException. Since it touches on the behaviour of Cukedoctor itself, I couldn't allow myself to add an assert or Objects.requiresNonNull.

rdlopes commented 2 years ago

need to close this one, it's outdated given that you've managed to update lots on your own.