rmpestano / cukedoctor

BDD living documentation using Cucumber and Asciidoctor: https://goo.gl/Yp3NiU
https://rmpestano.github.io/cukedoctor/
Apache License 2.0
121 stars 23 forks source link

feat(converter): add a cukedoctor language tag @language-<language> #264

Closed rdlopes closed 2 years ago

rdlopes commented 2 years ago

Hi Raphaël, since I'm using Cucumber 7, I have been facing the disappearance of the language feature.

This, because Cucumber decided to stop supporting comments in JSON files. So now, language comments are not anymore properly set in JSON features and the i18n is not working.

This change aims at adding a tag @language-(en|es|fr|ge|pt), to mimic the behavior or ordering and allow users to update their Cucumber version.

rmpestano commented 2 years ago

Hi again @rdlopes, I just rebased again and fixed the conflicts. Preferable I try to keep a linear history so I removed the merge commit:

Screen Shot 2022-07-30 at 18 49 11 Screen Shot 2022-07-30 at 19 16 29
rdlopes commented 2 years ago

No problem for me. I'll keep that in mind.