search

rmpestano / cukedoctor

BDD living documentation using Cucumber and Asciidoctor: https://goo.gl/Yp3NiU
https://rmpestano.github.io/cukedoctor/
Apache License 2.0
121 stars 23 forks source link

Build - Remove warnings and errors #266

Closed rdlopes closed 2 years ago

rdlopes commented 2 years ago

This PR is meant to clean the workspace and build from errors / warnings produced by the build and build output.

rdlopes commented 2 years ago

Ouch, didn't see that there has been an update. I need to rebase !

rmpestano commented 2 years ago

Hi @rdlopes, thanks a lot for this huge effort!

Two things regarding this PR:

1 - I couldn't rebase with master in a "normal way", I had to "squash" all your commits and then rebased with master because you have an "weird" git tree (you had some commits from master and a merge commit that makes it hard to rebase). Can I push my local branch to your PR? if you prefer to do it yourself here are the steps I did in order to fix the git tree:

2 - The second point is about the parent module, do we need it to fix warnings? If possible I'd like to use current parent pom as parent

Thank you again!

rdlopes commented 2 years ago

You're right, it's a mess as I was playing with formatting in the middle. Rebuilt a PR for that matter, properly set.

Removed the project cukedoctor-parent but still pulled up dependencies and plugins versions to the parent, so enforcer and maven-duplicate-finder are happy.

Actually, now that SLF4J has been fixed, we can see errors that were hidden, in the past, nice thing. The new PR is #267 and this one will be closed, so we leave it to history.