rmrector / service.stinger.notification

MIT License
1 stars 2 forks source link

End of movie chapter #5

Open KarellenX opened 1 year ago

KarellenX commented 1 year ago

Hi @rmrector

I have used this addon for many years, but I have always noted that it is very hit-and-miss with the notifications, more times than not never receiving a notification pop-up.

I believe the problem stems from many (most in my collection of movies) including an end of movie chapter as shown in the screenshot. These are rips from blurays, not chapter files I created.

Because of this chapter mark at the end of the movie, it delays the notification until a point after when most people have stopped the movie as credits have started to roll.

Is it possible to change the notification to display at, say, the third last chapter?

Also is it possible to have different icons for aftercreditsstinger and duringcreditsstinger? Maybe a third icon for when both are in the movie?

Thanks.

stinger

rmrector commented 1 year ago

Is it possible to change the notification to display at, say, the third last chapter?

A setting could be added. I don't see that happening much in my library, but it's hard to say how often I've edited them out. I didn't think I do that very often, but double-checking my Last Stand disc I surely did for that movie.

Also is it possible to have different icons for aftercreditsstinger and duringcreditsstinger? Maybe a third icon for when both are in the movie?

Sure. The default design shows the logo popup as solid if there is only aftercreditsstinger and semi-transparent if a duringcreditsstinger. It's a skinnable window with all three states noted in a window property, so the skinner can tell which applies.

KarellenX commented 1 year ago

The default design shows the logo popup as solid if there is only aftercreditsstinger and semi-transparent if a duringcreditsstinger

Thanks I never noticed that. I'll be more aware of it next time.