rmrevin / yii2-minify-view

Yii2 View component with minification css & js
MIT License
191 stars 67 forks source link

plz update your repo #52

Closed hooman-mirghasemi closed 7 years ago

hooman-mirghasemi commented 7 years ago

Hi in php 7.1.13 I see a error in your repo dependency "mrclay/minify". error is in "CSSmin" class in this method: private function normalize_int($size) { if (is_string($size)) { switch (substr($size, -1)) { case 'M': case 'm': return $size 1048576; case 'K': case 'k': return $size 1024; case 'G': case 'g': return $size * 1073741824; } }

    return (int) $size;
}

it is because $size has "M" suffix like "300M" and in new php version it can not multiple, but work in older php version.

I found that mrclay/minify have new version 3 and i suggest you to update your repo for compatibility with this new version.

CyanoFresh commented 7 years ago

+1

CyanoFresh commented 7 years ago

https://github.com/rmrevin/yii2-minify-view/pull/53

rmrevin commented 7 years ago

Hi. I'm sorry for the long answer. I was not available. Fixed in version 1.15.0

hooman-mirghasemi commented 7 years ago

thank you . i think you forget that push update button in packagist, yet last version is 1.14.4 when i try to update it: composer update rmrevin/yii2-minify-view Loading composer repositories with package information Updating dependencies (including require-dev) Nothing to install or update Generating autoload files

https://packagist.org/packages/rmrevin/yii2-minify-view