search

rmrevin / yii2-minify-view

Yii2 View component with minification css & js
MIT License
191 stars 67 forks source link

Add missing preg_replace in removeJsComments() #59

Closed acerix closed 6 years ago

acerix commented 6 years ago

Add regex from https://stackoverflow.com/a/31907095 to placeholder function for removing JavaScript comments.

rmrevin commented 6 years ago

Hi, thanks for the pull request. For approval you need to add unti test for this case.

acerix commented 6 years ago

Good call, I added a test case, thanks.

rmrevin commented 6 years ago

Thanks.