search

rmrevin / yii2-minify-view

Yii2 View component with minification css & js
MIT License
191 stars 67 forks source link

Copy CSS print query from link to minified CSS #60

Closed acerix closed 6 years ago

acerix commented 6 years ago

For example, fullcalendar includes a separate CSS file for printers like this:

<link href="fullcalendar.print.css" rel="stylesheet" media="print">

The media="print" part currently gets lost, so CSS which is intended for printers only is applied on screen view.

The patch puts wraps such CSS with @media print {} so it only applies on printers.

rmrevin commented 6 years ago

Hi, thanks for the pull request. For approval you need to add unti test for this case.

acerix commented 6 years ago

Added test case and made it more general (apply to type=screen, etc. as well), thanks

rmrevin commented 6 years ago

Thanks.