search

rmrk-team / rmrk-substrate

[WIP] RMRK Substrate pallets
https://rmrk.app
Other
74 stars 36 forks source link

implement test for burn_nft max_recursions #128

Closed bmacer closed 2 years ago

bmacer commented 2 years ago

addresses the missing test for #107

HashWarlock commented 2 years ago

Nice. Does this means we should have a limit to children a NFT can contain? Or would we need to somehow have a way to manage the parent-less children so they can be properly burned?

bmacer commented 2 years ago

In practice, I'm hopeful we won't reach this limit, but it seems we could just put the burden on the client to destroy mid-generational NFTs prior to burning the highest-level ancestor. It's possible we could implement some solution but I think it's enough of an edge case to not really care about at this point.

Unless I'm mistaken. when you say "limit to children a NFT can contain", do you mean direct children? This is a generational limit, not a one-generation children issue. Are you seeing a different concern here?