search

rmrk-team / rmrk-substrate

[WIP] RMRK Substrate pallets
https://rmrk.app
Other
74 stars 36 forks source link

ComposableResources and SlotResources are unused storages, should be deleted #170

Closed bmacer closed 2 years ago

bmacer commented 2 years ago

Quite sure all of the storages go directly to Resources, regardless of type, so it should be safe to delete these two storages

https://github.com/rmrk-team/rmrk-substrate/blob/3034ae31467eb3cda08f0a92203a3729b9b4e44b/pallets/rmrk-core/src/lib.rs#L160-L186

bmacer commented 2 years ago

Indeed we do use these storages. ComposableResource is populated during add_composable_resource and is used to check for the existence of a base on an NFT during equip in the equip pallet. Similarly, SlotResource is used for ensuring the existence of a slot on a particular NFT's particular resource when doing an equip in the rmrk-equip pallet.

Proposing changing these names to be more clear ComposableResources -> EquippableBases SlotResources -> EquippableSlots