search

rmrk-team / rmrk-substrate

[WIP] RMRK Substrate pallets
https://rmrk.app
Other
74 stars 36 forks source link

Remove Locks when selling or unlisting an NFT #267

Closed HashWarlock closed 1 year ago

HashWarlock commented 1 year ago

Description

Currently Locks are set to false instead of being removed whenever they are released in unlist_nft and accept_offer. We should remove the Lock to reduce space.

Szegoo commented 1 year ago

@HashWarlock Just to let you know so that you don't work on something that has already been done, a small part of this issue has been fixed here. I assume that the PR for this issue would also make a migration to remove unnecessary storage items. And I assume that a test could be written for this. So do you want me to revert the lines I have changed inside my PR regarding this issue so that there would be a separate PR for this?

HashWarlock commented 1 year ago

@HashWarlock Just to let you know so that you don't work on something that has already been done, a small part of this issue has been fixed here. I assume that the PR for this issue would also make a migration to remove unnecessary storage items. And I assume that a test could be written for this. So do you want me to revert the lines I have changed inside my PR regarding this issue so that there would be a separate PR for this?

Nvm I just read your PR and that is the fix I need. Thanks for adding that.