search

rmrk-team / rmrk-tools

Tools for the RMRK NFT standard on Kusama
GNU General Public License v3.0
96 stars 36 forks source link

Change transferable check #100

Closed Erebos0506 closed 2 years ago

Erebos0506 commented 2 years ago

Added check for negative number and exluded delisting there

Erebos0506 commented 2 years ago

It might be a better idea though to not add the negative number check for the buy interaction to prevent Nfts from being shown as listed and nobody being able to buy them even if that causes the Nft to actually be transferable when it shouldn't be

Yuripetusko commented 2 years ago

Would be amazing if you could add a small unit test case in test/2.0.0/consolidator/send.test.ts but this is optional

Erebos0506 commented 2 years ago

I'll try no promises though as i never did it before

Yuripetusko commented 2 years ago

I'll try no promises though as i never did it before

you should be able to work it out, and later run. yarn test:2.0.0:watch to see if they are passing

Erebos0506 commented 2 years ago

I'll try no promises though as i never did it before

you should be able to work it out, and later run. yarn test:2.0.0:watch to see if they are passing

I didn't find a way to set the blocknumber for the remarks so that i either got an error message that the nft is non existent or an error that there was no error when trying

Erebos0506 commented 2 years ago

Decided to remove the check from buy afterall to prevent nfts being stuck as listed

Yuripetusko commented 2 years ago

couldn't add unit tests to your PR so created a new one

https://github.com/rmrk-team/rmrk-tools/pull/106/files