rmst / yoke

Turns your Android device into a customizable gamepad for Windows/Mac/Linux
MIT License
219 stars 24 forks source link

Style, code simplification and pushable joysticks #59

Closed medape closed 3 years ago

medape commented 3 years ago

Comments should be self-explanatory.

This branch fixes a couple bugs, but the most notable changes are:

This last change allowed me to change the gamepad layout to something resembling much more closely an X-Box controller. (Labels and colours intentionally don't match X-Box but they're trivial to change.)

In spite of the name of the branch, this doesn't add direct support for XInput games; games that specifically search for XInput or DirectInput devices (like Genshin Impact) won't be able to use vJoy, and I still haven't found a good solution for this. The one I've been testing now (chaining Yoke output to X360CE) adds latency, probably because of misconfiguration or because of having to install several device emulators.

Despite this, #57 has been fixed since #58: there is no noticeable input lag from the phone to the vJoy Monitor, nor from the phone to jstest-gtk.

(Edited to remove repeated words.)

pzmarzly commented 3 years ago

Thanks a lot for this PR. I'll merge it tomorrow if that's OK with you (if you don't plan to introduce more changes here).

medape commented 3 years ago

Thank you for everything. Feel free to merge, I don't plan on adding more changes for now.