search

rmtew / incursion-roguelike

The legendary computer game Incursion: Hall of the Goblin King!
https://incursion-roguelike.net/
Other
9 stars 1 forks source link

Ensure tracked generated files are rebuilt in tests #35

Closed HexDecimal closed 3 months ago

HexDecimal commented 3 months ago

Normal builds would assume that generated files are already built based on their timestamps which prevents testing newly updated generated files. /t:rebuild should always do a clean rebuild.

HexDecimal commented 3 months ago

I'm having a hard time verifying this. Your idea of deleting the files is probably easier to do.

HexDecimal commented 3 months ago

Reference to the commit conversion because I don't want to have trouble hunting it down later: https://github.com/rmtew/incursion-roguelike/commit/40c235d264a29e4e48870f513f7f0f593c4e86f4

rmtew commented 3 months ago

I am pretty sure I always hit the rebuild hotkey just to be sure (ctrl+shift_b) and it does not rebuild these files because it does not change the gnerated output in any way by doing that rebuild.

HexDecimal commented 3 months ago

For now I'm going to take the fact that the x64 builds didn't fail as proof that this method doesn't work.

HexDecimal commented 3 months ago

Files are now deleted by the CI before building, only (Debug, Win32) is able to actually build these files as usual.