rmurphey / js-assessment-answers

125 stars 84 forks source link

Solved all exercises #18

Closed surtich closed 10 years ago

surtich commented 10 years ago

I have provided a different solution for case that you think improves the original solution.

You can review FizzBuzz, permute or curryIt functions, for example.

Great job, by the way.

rmurphey commented 10 years ago

@IGZJavierPerez can you update your pull request to match the indentation of the existing code? Most notably, your pull request uses four spaces for indentation, where the existing code uses two. Also, the existing code uses semicolons consistently, while your code does not.

Additionally:

Even with these changes, I am not sure that I will accept this pull request wholesale. You may want to make smaller pull requests for particular answers that you feel you have improved significantly.

surtich commented 10 years ago

Ok, you are right. I will do it.