search

rmurphey / js-assessment

A test-driven approach to assessing JS skills
5.15k stars 2.05k forks source link

TDD: Game of Life #11

Closed jtmalinowski closed 12 years ago

jtmalinowski commented 12 years ago

So Conway's GoF, it's even kind of tradition at CodeRetreats to have (1) a list of tests and make code pass one more test each iteration. Make a commit each iteration. Or the other way - (2) you have many iterations of code and you gotta create tests, add one test per each iteration.

If you're okay with that, I'll push it when I have a few spare hours. You do both at CodeReatreat, but (1) sounds more convincing to me in this case.

rmurphey commented 12 years ago

I'm not familiar with CodeRetreats or with the exercise you're talking about, but if you can submit a pull request that shows what you have in mind, I'll take a look :) However, I'm wondering whether this is a good fit in this repo, or if it might be better as its own standalone repo? Or maybe it will be sufficient to just make it its own test file. Either way, if you want to take a stab at it, we can discuss the best home for it later.

wilmoore commented 12 years ago

Hi @jakubmal -- I think this would be great standalone; however, it doesn't seem to fit with the theme of this repo. I mean, "Cellular Automata" is an interesting topic but it seems like such a digression from everything else that it would make this a huge turn-off. Again, good idea in general and could definitely stand to be a standalone suite.

BTW, I think you may have meant "CGOL" (conway's game of life) rather than "GoF" (gang of four). Not trying to be a smarty, but just want to make sure that anyone passing through that hasn't looked into CGOL and Cellular Automata isn't violently confused.

jtmalinowski commented 12 years ago

Hi, I'm not really familiar with this "gang of four" stuff, but it sounds bad. I actually did a pull request a few weeks after I had opened this issue. Then Rebecca wrote what you just wrote, that I should find another place for this code, so I closed the pull request and let the code die, or maybe it's still hanging on some branch.

Anyway, I should have closed this issue as well. My bad, sorry.