search

rmurphey / js-assessment

A test-driven approach to assessing JS skills
5.15k stars 2.05k forks source link

Disallow user returning result rather than expression for logicalOperators.js #115

Closed jacobroufa closed 9 years ago

jacobroufa commented 9 years ago

I'd like to resolve #62 with this commit. Per @PAkerstrand's provided solution, this commit disallows a user from returning the result of a logical operator rather than the operation expression itself.

ashleygwilliams commented 9 years ago

hey @jacobroufa! this is definitely a good check. thanks for the PR!

however, we need to keep the number tests in- for an explanation see https://github.com/rmurphey/js-assessment/commit/070eee73367b37e79d452281929216b52fbc848a

can you update to not remove those and then squash? thanks!

jacobroufa commented 9 years ago

There we are. I added a comment on the previous line for both assertions in the event that anyone will want to edit this file again they are aware of the reason. Let me know if this works for you!

PAkerstrand commented 9 years ago

:+1:

ashleygwilliams commented 9 years ago

hey @jacobroufa looks perf except could you make it a single commit instead of two?

jacobroufa commented 9 years ago

Sorry about that. See c26ce62.

ashleygwilliams commented 9 years ago

:tada: thanks! @jacobroufa