Closed jacobroufa closed 9 years ago
awesome. waiting on #112 to merge, will likely need a rebase :wink:
@jmeas I could build that out if you like. i don't know that it's necessary, but you're right that it will be far more precise and useful in that way.
@ashleygwilliams I've merged this with the changes from #112.
@jmeas Let me know if the solution in e896f70 satisfies your requirements.
/me shrugs -- No particular reason.
@jacobroufa i think it might be more explicit to have this.clock.tick(100)
than storing t
as a var in the for
loop
otherwise i'm good with this :+1:
Fixed. Let me know if you need anything else! :+1:
@jmeas removed the call to done()
.
Eeek! Sorry!! That was a total bonehead maneuver.
@jmeas can you do the final review and merge on this when it's ready? i think you have a better vision of the final than i do
I know I'm late, but :+1:. I prefer this more complete solution to my little band-aid patch in #114. :)
@jmeas have you had a chance to look this over? Is there anything else I need to do prior to merge?
Yo! Sorry it took me so long to review this! This is really dope, @jacobroufa . Thanks for puttin' the work together :D
:sparkling_heart: :sparkles:
With the intent to resolve #114 per @jmeas' suggestion, this commit adds sinon.js and modifies the count.js test to use fake timers.