Updates to #112 refactor - Githubissues

rmurphey / js-assessment

A test-driven approach to assessing JS skills

5.15k stars 2.05k forks source link

Updates to #112 refactor #122

Closed jamesplease closed 9 years ago

jamesplease commented 9 years ago

Ready for review/merge!

Updates

Adding jQuery to the package.json. I received an error when I tried to load the tests in the browser 'cuz it couldn't find jquery.
Update README text w. changes
Fix a failing test
To investigate

The following solutions are failing:

~~logical operators~~
- ~~you should be able to work with logical and (✘ This works on master)~~ Fixed!
~~permutation~~ (https://github.com/rmurphey/js-assessment-answers/issues/33)
- ~~you should be able to return the nth number in a fibonacci sequence~~
- ~~you should be able to return the set of all valid combinations of n pairs of parentheses.~~

jamesplease commented 9 years ago

There were 3 failing tests. Two are missing answers; the other does work on master. Working to fix it now!