search

rmuslimov / browse-at-remote

Browse target page on github/bitbucket from emacs buffers
232 stars 53 forks source link

Bitbucket's line-jump syntax has changed #19

Open MatthewDarling opened 8 years ago

MatthewDarling commented 8 years ago

Right now, browse-at-remote specifies the line to jump to in Bitbucket like this:

#cl-108

However, the working format seems to be this:

#core.clj-108

Where "core.clj" is the name of the file. As in, for "x/y/z/core.clj", it's "core.clj", ignoring the parent directories.

rmuslimov commented 8 years ago

Thanks, for reporting - I'll check and fix.

rmuslimov commented 8 years ago

You know I just found time to take a look on this, and old way for bitbucket urls works fine now. May it was temporary issue?

MatthewDarling commented 8 years ago

Hmm, maybe the #cl-108 doesn't do what I thought. Testing it this morning, it highlights the line in question, but without scrolling down to that line. So it does something. However, the #core.clj-108 does the highlighting, but also scrolls to that line.

Maybe there's an extra comment needed to do the scrolling?