search

rmuslimov / browse-at-remote

Browse target page on github/bitbucket from emacs buffers
233 stars 54 forks source link

Reliably extract SHA1 from magit-revision buffers #55

Closed jwhitbeck closed 5 years ago

jwhitbeck commented 5 years ago

Hi @rmuslimov

Thanks for your work on the browse-at-remote package. It's become a major part of my daily workflows.

Recently, I've encountered issues with some magit buffers. In particular, the first line on the magit-revision buffer sometimes contains extra information before the SHA1. Examples:

origin/master 895e60b602f23d694674d977f24bd7a213a03aa6
0.10.0 47bab994640f086939c30cc6416e770ad067e950

Here is a quick patch to handle these cases.

rmuslimov commented 5 years ago

Hey, John! Thanks you! Actually, you've done a lot too and thank you for sharing you commits with us.