rmuslimov / browse-at-remote

Browse target page on github/bitbucket from emacs buffers
232 stars 53 forks source link

Can't browse at remove after the package update #79

Closed achempion closed 3 years ago

achempion commented 3 years ago

Right now when I call browse-at-remote function I get the message

browse-at-remote--get-remote-type: Sorry, not sure what to do with domain ‘github.com’ (consider adding it to ‘browse-at-remote-remote-type-domains’)

but I already have GitHub domain in a variable

browse-at-remote-remote-type-domains is a variable defined in ‘browse-at-remote.el’.
Its value is shown below.

  You can customize this variable.

Documentation:
Alist of domain names to remote types.

Value:
(("bitbucket.org" . "bitbucket")
 ("github.com" . "github")
 ("gitlab.com" . "gitlab")
 ("git.savannah.gnu.org" . "gnu")
 ("gist.github.com" . "gist")
 ("git.sr.ht" . "sourcehut")
 ("vs-ssh.visualstudio.com" . "ado")
 ("pagure.io" . "pagure")
 ("src.fedoraproject.org" . "pagure"))

[back]

My version is 20210527.451 and I didn't make any modifications related to this package.

rmuslimov commented 3 years ago

This was my bad with merging and pushing untested changes, fixes this in latest commit. Please let me know if issue is still there. cc @jackrosenthal

jackrosenthal commented 3 years ago

Thanks. We should add in a bit more test coverage here :)