search

rmuslimov / jenkins.el

Jenkins plugin for emacs
79 stars 30 forks source link

Use cl-labels instead of defun-in-defun #3

Closed syohex closed 9 years ago

syohex commented 9 years ago

We should use cl-lables or similar API for defining local functions.

rmuslimov commented 9 years ago

Thanks, @syohex! I didn't know about cl-flet, cl-labels before.

rmuslimov commented 9 years ago

I temporary reverted this merge, because I've started to get exception when I'm trying to switch to details page:

mapcar: Symbol's function definition is void: convert-item
syohex commented 9 years ago

Ah, sorry. I suppose I should use #'convert-item instead of 'convert-item

syohex commented 9 years ago

Could you try following patch ? I use #'convert-item instead of 'convert-item

https://gist.github.com/syohex/afc8b08f62f0eb28b7c0

rmuslimov commented 9 years ago

Thanks, it's worked!