search

rmuslimov / jenkins.el

Jenkins plugin for emacs
79 stars 30 forks source link

jenkins-hostname expects a trailing slash #9

Closed brcm-ruperts closed 9 years ago

brcm-ruperts commented 9 years ago

The variable jenkins-hostname gets used in jenkins-jobs-view-url in a way that assumes it has a slash at the end. This doesn't really match the usual meaning of "hostname", which would be something like jenkins.my-company.com.

noorul commented 9 years ago

Also this assumes that host name contains protocol. For me just hostname/ does not work, I need to give http://hostname:port/. Also I think we can separate out port. If not we can re-name the variable to something like jenkins-url

rmuslimov commented 9 years ago

You're right, I just replaces jenkins-hostname with jenkins-url variable. I think now it ok for this variable assume that it has slash in the end. @noorul You can just port in this jenkins-url variable ( as you could in jenkins-hostname before). I guess now it more clear and predictable behaviour ( to have everything protocol, domain and port at the same place)

rmuslimov commented 9 years ago

Since somebody already have installed this package I left things as backward compatible and will replace them as some point in future. Thanks, for finding this issue. @brcm-ruperts @noorul