Description of the regression is at the commit message.
While we're at this subject, friendly reminder to remove the euro input and euro feature except the CP change.
And consider changing the console CP to ACP, similar to what the euro feature does but better. It should fix all mismatches between the console CP and ACP on all systems, including replacing the euro fix, and could also get rid of the conversions as long as the CP doesn't change.
Alternatively, consider using a readConsoleInput_acp variant which simply bypasses the input CP and delivers bytes in ACP regardless of the console CP. That should be simple, and equivalent to changing the input CP to ACP, and would get rid of the input conversion unconditionally, because it simply doesn't depend the input CP anymore.
Description of the regression is at the commit message.
While we're at this subject, friendly reminder to remove the euro input and euro feature except the CP change.
And consider changing the console CP to ACP, similar to what the euro feature does but better. It should fix all mismatches between the console CP and ACP on all systems, including replacing the euro fix, and could also get rid of the conversions as long as the CP doesn't change.
Alternatively, consider using a
readConsoleInput_acpvariant which simply bypasses the input CP and delivers bytes in ACP regardless of the console CP. That should be simple, and equivalent to changing the input CP to ACP, and would get rid of the input conversion unconditionally, because it simply doesn't depend the input CP anymore.