search

rmyorston / busybox-w32

WIN32 native port of BusyBox.
https://frippery.org/busybox
Other
674 stars 124 forks source link

win32: UCRT: avoid I64 printf format warnings #356

Closed avih closed 1 year ago

avih commented 1 year ago

Builds without warnings on: mingw-msvcrt gcc 13.2 i686/x86-64 (w64devkit). mingw-ucrt gcc 13.1/13.2 i686/x86-64 (winlibs).

Where previously both the ucrt builds warned about I64.

avih commented 1 year ago

Reminder: try "rebase and merge" ;)

rmyorston commented 1 year ago

Reminder: try "rebase and merge" ;)

I did. I still don't like working on GitHub.

avih commented 1 year ago

I did. I still don't like working on GitHub.

You could also do this to apply the patch[set] on top of your current git HEAD:

curl https://github.com/rmyorston/busybox-w32/pull/356.patch | git am

(just add .patch to the PR URL and it will redirect to the patchset of the PR).

Though i think rebase/am are only good for unsigned commits (like mine).

I think you can't rebase already-signed commits, so merge might be the only option (unless it's already on top of HEAD?). Not 100% sure though.