search

rmyorston / busybox-w32

WIN32 native port of BusyBox.
https://frippery.org/busybox
Other
670 stars 124 forks source link

`make check name=value` does not work #406

Closed smalltalkman closed 4 months ago

smalltalkman commented 4 months ago

When compiling some software, the make check name=value style command cannot be used, but the make name=value check form must be used. for example:

# make WINDOWS_STAT_INODES=1 check VERBOSE=yes KEEP=yes TESTS=binary

Error reported:

make: invalid target name 'VERBOSE=yes'
rmyorston commented 4 months ago

In the POSIX standard for make the SYNOPSIS lists macro assignments before targets on the command line. In the OPERANDS section it says:

If the target_name and macro= value operands are intermixed on the make utility command line, the results are unspecified.

busybox-w32 make doesn't currently allow intermixing. If it ever does it will be as a non-POSIX extension.

smalltalkman commented 4 months ago

busybox-w32 make doesn't currently allow intermixing. If it ever does it will be as a non-POSIX extension.

Thank you for considering this feature.

rmyorston commented 4 months ago

I've added an extension to busybox-w32 make to allow mixing of macros and targets on the command line.

Please try the latest prerelease binary (PRE-5329 or above).

smalltalkman commented 4 months ago

Please try the latest prerelease binary (PRE-5329 or above).

Thank you so much! Testing will take place at some point in the future.

smalltalkman commented 4 months ago

Please try the latest prerelease binary (PRE-5329 or above).

Thank you so much! Testing will take place at some point in the future.

It works very well. Thanks again!