search

rnabioco / valr

Genome Interval Arithmetic in R
http://rnabioco.github.io/valr/
Other
88 stars 25 forks source link

rchk issue #365

Closed jayhesselberth closed 4 years ago

jayhesselberth commented 4 years ago

The rchk checks I ran didn't throw this error, but it happened on CRAN. Not sure how to reproduce it locally. We'll need to fix and do a patch release.

https://raw.githubusercontent.com/kalibera/cran-checks/master/rchk/results/valr.out

Package valr version 0.6.0
Package built using 78358/R 4.1.0; x86_64-pc-linux-gnu; 2020-05-04 22:51:12 UTC; unix   
Checked with rchk version 490627e4fb8e93244230dbbd61455730aa43c328
More information at https://github.com/kalibera/cran-checks/blob/master/rchk/PROTECT.md

Function init_factor(SEXPREC*, SEXPREC*)
  [UP] unprotected variable factor_string while calling allocating function Rf_setAttrib(?,S:levels,?) valr/src/valr_utils.cpp:23
kriemo commented 4 years ago

It looks like I called UNPROTECT too early when setting factor levels. I'll test out a few VMs to see if I can reproduce the rchk errror to confirm the fix.

jayhesselberth commented 4 years ago

You could also retry the rchk calls in #359, in retrospect the rchk VMs may just have been flaky yesterday and not finishing.