search

rnabioco / valr

Genome Interval Arithmetic in R
http://rnabioco.github.io/valr/
Other
88 stars 25 forks source link

update intervaltree #391

Closed kriemo closed 2 years ago

kriemo commented 2 years ago

passes tests and checks but want to run through valgrind and ASAN/UBSAN before merging.

closes #349

kriemo commented 2 years ago

I wasn't able to set up ubsan/asan testing due to challenges getting dependencies installed. valgrind however reported no issues so I believe this should be ready to go. Performance is slightly slower with the updated interval tree.

jayhesselberth commented 2 years ago

This looks good. I think the small drop in performance is a good trade off for increased maintainability.

We should be more explicit about acknowledging the IntervalTree code from ekg, probably in the comments of IntervalTree_ext.h