search

rnabioco / valr

Genome Interval Arithmetic in R
http://rnabioco.github.io/valr/
Other
88 stars 25 forks source link

remove `r_index` from df subset fxns #406

Closed jayhesselberth closed 1 year ago

jayhesselberth commented 1 year ago

this is a cleanup. r_index is never used (i.e., it's always set to false), which leads to a compiler warning on os x (i is never init in valr_utils.cpp).

kriemo commented 1 year ago

thanks, looks good to me. Out of curiosity which compiler on osx is reporting the warning? I don't see if on my end on osx with clang:

clang --version

Apple clang version 13.0.0 (clang-1300.0.29.30)
Target: arm64-apple-darwin21.3.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
jayhesselberth commented 1 year ago

Looks like this happens in newer versions, here's mine:

$ clang --version
Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Target: arm64-apple-darwin22.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin