search

rnadler / ng2-password-strength-bar

Angular 2/4/5 Password Strength Bar
http://bobonmedicaldevicesoftware.com/blog/2016/12/09/publishing-an-angular-2-component-npm-package/
MIT License
20 stars 17 forks source link

Change detection OnPush maybe? #2

Open karolmie1 opened 7 years ago

karolmie1 commented 7 years ago

All changes are done on Input change, so OnPush strategy would be viable, and would provide that sweet sweet performance boost.

changeDetection: ChangeDetectionStrategy.OnPush`

charlesc-ai commented 7 years ago

@karolmie1 Hello, did you succeed on importing this Module in App.module.ts?

karolmie1 commented 7 years ago

I'll try to prepare fix for #1, probably no earlier than on weekend. I'll have to learn a bit about creating typings for npm packages first.