search

rnadler / ng2-password-strength-bar

Angular 2/4/5 Password Strength Bar
http://bobonmedicaldevicesoftware.com/blog/2016/12/09/publishing-an-angular-2-component-npm-package/
MIT License
20 stars 16 forks source link

Expose strength in component API [closes #2, #17 and #20] #23

Closed vicsstar closed 6 years ago

vicsstar commented 6 years ago

Exposes the strength via an EventEmitter, emitting the current strength as the only single parameter, in response to changes to the password.

rnadler commented 6 years ago

@vicsstar Thank you for the PR!

Please take a look at the changes I made on the vicsstar-enhancement/expose-strength branch.

Besides some README.md clean-up, the logic did not emit the strength event on an empty string.

If you don't have any objections I will merge the PR and push a new version to NPM.

vicsstar commented 6 years ago

Totally missed that if-password block; thanks! Looks good to me, no objections. Feel free to merge when ready.

Thanks!