search

rnburn / zipkin-cpp-opentracing

OpenTracing Tracer implementation for Zipkin in C++
Apache License 2.0
51 stars 45 forks source link

Track dropped spans #11

Closed KevinMGranger closed 4 years ago

KevinMGranger commented 6 years ago

The second half of the work from #9.

This is a bigger change, so I'd appreciate feedback.

I'd like to add in more unit testing for this stuff, but haven't yet.

rnburn commented 6 years ago

Instead of naming methods getXyz can you simply use xyz. The code was originally taken from Envoy and that matches with the style used elsewhere.

KevinMGranger commented 6 years ago

Feedback implemented.

rnburn commented 6 years ago

@KevinMGranger -- how's this going? it looked like there was only a few issues left.

KevinMGranger commented 6 years ago

Sorry for the holdup, I've been busy with some other work.

I've also been trying to figure out a good testing strategy for this, unless you think the changes are simple enough that we don't need to worry about it.