search

rnburn / zipkin-cpp-opentracing

OpenTracing Tracer implementation for Zipkin in C++
Apache License 2.0
51 stars 45 forks source link

Collector endpoint path supporting Zipkin v1 or v2? #28

Open nobeh opened 6 years ago

nobeh commented 6 years ago

In this comment, it is stated that zipkin-cpp-opentracing supports Zipkin v2 format:

the zipkin c++ library currently only supports the V2 style spans

But when looking at zipkin_core_constants.h, the collector API sounds different: 

const std::string DEFAULT_COLLECTOR_ENDPOINT = "/api/v1/spans"

Testing with nginx and this module, it seems to be working even with a v2 collector endpoint.

Is this a configuration bug? Could you please confirm which version is supported? And maybe, make the endpoint API path also a configuration?