search

rnc-archive / .github

This repository contains the general guidelines for the RNCommunity org
https://github.com/react-native-community
200 stars 31 forks source link

Chore: adding templates for issues and PRs #27

Closed kelset closed 5 years ago

kelset commented 5 years ago

This wants to start tackling #3.

To start "easy" with something that every repo could use, I decided to take inspiration from RN main repo's templates to create a small set of templates that should cover most cases for all the repos.

I'm pretty sure that these files will only appear in any other repo in the org only if there is no .github... but I guess we'll only find out.

Please let me know what you think of the copy 🤗 or if there is anything else that you think should be added.

mikehardy commented 5 years ago

LGTM - I could use each of these issue templates, but the pull request one we have already is nice as it is a checklist that helps set expectations of what we'll ask for prior to merge, though your copy is better: https://github.com/react-native-community/react-native-device-info/blob/master/.github/pull_request_template.md

pedpess commented 5 years ago

@kelset Good idea on having those! :+1: ... I added some single comments in the files you sent. :)

kelset commented 5 years ago

Just to be clear, AFAIK if the repo at any point creates local versions of these files, they would take priority over these defaults. So nothing should get overwritten.