rnc-archive / .github

This repository contains the general guidelines for the RNCommunity org
https://github.com/react-native-community
200 stars 31 forks source link

Organisation updates - PLEASE READ ❤️ #40

Closed kelset closed 4 years ago

kelset commented 5 years ago

👋 folks!

As you may have noticed, I've (finally!) managed to work on #1 and finish it - if something doesn't look right submit a PR and/or let me know!

Aside from that, I've also added all the maintainers to the github org and to a team called Maintainers. This should have happened gradually when you were added as maintainers for any of the orgs, and it was long overdue and I'm sorry it took me so long to push this forward.

(btw in case now you are receiving notifications for all the repos in the org, I'd recommend to simply unwatch the ones you are not working on 🤗)

All of this should help you all to keep track of things going on, and finally recognise you as part of the community 🤗

A few more comms, in case you missed:

Lastly, as members of the comm, as discussed in #5, you can quickly jump around and help each other; I'd suggest that, following this change in auth, you do a couple things in your repo:

  1. Add a codeowners file
  2. via the settings lock the master branch from direct commits (optional)
  3. set the PRs to require a review by one of the code owners, like so (in settings -> branches): Screenshot 2019-06-25 at 13 35 17

(to do this, btw, you need to be admin role in the repo you maintain - if you are not, please let me know and we'll fix that too!)

For anything, feel free to open an issue here or write in the Discord - see you around 👋

kelset commented 5 years ago

If I did things right, If I write this now I'll ping you all in one shift move @react-native-community/maintainers 😅

FonDorn commented 5 years ago

@kelset will do. Please give me admin role to Masked View repo

mmazzarolo commented 5 years ago

@kelset thanks for the recap! react-native-modal is now up to date. cc: @rewieer

CHaNGeTe commented 5 years ago

there is an eslint config all repos should use, you can read more here #2

Where is the mentioned eslint?

matt-oakes commented 5 years ago

@CHaNGeTe Inside the main React Native repo here: https://github.com/facebook/react-native/tree/master/packages/eslint-config-react-native-community

kelset commented 4 years ago

Hey folks, I'm going to close this issue. I should have probably closed it off once I stopped being an owner of the org and while some conversation around this happened I feel that given the "0 executive power" of these conversations it's better to just close them off - so not to give the misleading signal that something is currently being done on my side (or by anyone tbh) around it.

If and when this topic will get picked up again it's much healthier for whoever will actually handle it to just open a new issue. I'm not against the new issue picking up this same conversation, even copy/pasting stuff from here - but I want to close the ones opened up by me off.