search

rnc-archive / .github

This repository contains the general guidelines for the RNCommunity org
https://github.com/react-native-community
200 stars 31 forks source link

Lean Core repositories #45

Closed kelset closed 4 years ago

kelset commented 5 years ago

👋 everyone.

I was checking the repositories to understand how many are from the Lean Core and, unless I've made mistakes, there are 25 repositories out of the 70 in the org that have been generated via this effort:

An issue I've noticed about them is that the way the repos "say" they are part of the Lean Core / come from the Lean Core is different, and a bit inconsistent. I mean, some don't even say it - here are a few examples:

I'd propose that we create a simple tag like https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square and we use that across all the different repos 🤗

matt-oakes commented 5 years ago

I'm actually not sure that it matters which repos are from the lean core effort and which aren't.

Before they were extracted it was a little arbitrary what was in core and what was a library. Lean Core to me was just moving things out of the core that shouldn't have been there in the first place.

The one thing that might need to be on the READMEs of extracted modules though is some instructions on how to migrate to the new library. There's some basic instructions in the NetInfo module.

kelset commented 5 years ago

Yeah, I mean - that's the extent of why I think we should do it:

The one thing that might need to be on the READMEs of extracted modules though is some instructions on how to migrate to the new library.

And aside from that, I think it would be good to link back to the main Lean Core issue because while we are a subgroup of super active users, many may not be aware of the whys and hows this has happened.

Hence why I proposed a tag - it would be a non-really-invasive way to have a link. A year from now likely we'll reach the point that you are describing of not needing to know / it not being relevant, but at the moment I feel that we are in a transition phase and some people may not know really what is going on.

matt-oakes commented 5 years ago

And aside from that, I think it would be good to link back to the main Lean Core issue because while we are a subgroup of super active users, many may not be aware of the whys and hows this has happened.

Hence why I proposed a tag - it would be a non-really-invasive way to have a link. A year from now likely we'll reach the point that you are describing of not needing to know / it not being relevant, but at the moment I feel that we are in a transition phase and some people may not know really what is going on.

Got it. That makes perfect sense to me then 👍

kelset commented 5 years ago

(and, also, I mean - consistency XD if we choose a style let's use it in all the repos - it's driving me crazy 😂)

matt-oakes commented 5 years ago

How does this work for you?

Lean Core Extracted

[![Lean Core Extracted](https://img.shields.io/badge/Lean%20Core-Extracted-brightgreen.svg)](https://github.com/facebook/react-native/issues/23313)
kelset commented 5 years ago

that looks so good ❤️ how did you do it? Is there a tool to create them? :3

matt-oakes commented 5 years ago

@kelset shields.io has a load of remade ones which call APIs to get information like download counts, issue counts, and loads of other stuff. Further down that page you can also just put in a title, message, and colour and it will generate you one. It's all hosted by them and based on the URL. They're really useful!

matt-oakes commented 5 years ago

Added that badge to the NetInfo README 👍

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and I will leave this open.

kelset commented 5 years ago

oh, right. This 😂

Well it's actually a good first issue in a way, no? XD

We could make a tweet via RNComm about it

kelset commented 4 years ago

Hey folks, I'm going to close this issue. I should have probably closed it off once I stopped being an owner of the org and while some conversation around this happened I feel that given the "0 executive power" of these conversations it's better to just close them off - so not to give the misleading signal that something is currently being done on my side (or by anyone tbh) around it.

If and when this topic will get picked up again it's much healthier for whoever will actually handle it to just open a new issue. I'm not against the new issue picking up this same conversation, even copy/pasting stuff from here - but I want to close the ones opened up by me off.