rnc-archive / react-native-drawer-layout

A platform-agnostic drawer layout for react-native
256 stars 63 forks source link

RN 0.42 not working #11

Closed kasterlod closed 7 years ago

kasterlod commented 7 years ago

DrawerLayout (tested on android only) --> navigator menu not hiding but slide to right and stop in the middle

new RN 0.42.0

DanielMSchmidt commented 7 years ago

This may be a duplicate of #3, I will have a look into it. Could be that this bug isn't fixed after all

DanielMSchmidt commented 7 years ago

Hi @kasterlod , I just found some time to look into this issue and I could not reproduce the bug on the iOS simulator or on my android device. Would you be able to provide a little example project where I can see the bug sothat I can debug it?

kasterlod commented 7 years ago

Hi!

Ok, so the problem was:

But now:

I'm using default code as below:

<DrawerLayout drawerWidth={250} drawerPosition={'left'} renderNavigationView={() => navigationView} ref={'DRAWER'}> <Toolbar <...some code...> /> <Navigator <...some code...> />

On the iOS there's everything work great. Thank's and greetings!

DanielMSchmidt commented 7 years ago

Can you verify that this is still a problem with the latest version published today?

kasterlod commented 7 years ago

Hi!

It seems like everything work now but still the toollbar is over the drawer.

greetings

DanielMSchmidt commented 7 years ago

Okay, I will start looking into this topic the next couple of days 👍

DanielMSchmidt commented 7 years ago

@kasterlod I debugged this problem, here is the comment about it: https://github.com/react-community/react-navigation/issues/709#issuecomment-290211241

DanielMSchmidt commented 7 years ago

Closing this for now, as this seems to be a problem in react-navigation itself