search

rnc-archive / react-native-drawer-layout

A platform-agnostic drawer layout for react-native
256 stars 63 forks source link

Update the iOS implementation with the accessibilityViewIsModal property on the View component. #5

Closed stefano-sarioli closed 7 years ago

stefano-sarioli commented 7 years ago

This change make the Drawer accessible by default when using VoiceOver on iOS.

The property will be exposed in a near future, we can let this pull request stay here till the property will not be implemented. The relative issue is this.

Let me know if I made something wrong, this is my first pull request on an open suorce project so please be kind.

stefano-sarioli commented 7 years ago

Sorry for the late answer. The property is now implemented on the master branch of RN, I don't know in which stable release it will be included.

Thanks for approving my pull request. I will ping you when the property will be released on an official release.

DanielMSchmidt commented 7 years ago

@StefanoSarioli Thank you 👍

stefano-sarioli commented 7 years ago

Hey, React Native 0.43 is here and it brings the new accessibilityViewIsModal property with it. We can merge this now. Thank for you hard work. Stefano

DanielMSchmidt commented 7 years ago

Thank you, I will do so later today 👍

DanielMSchmidt commented 7 years ago

I made severe changes to the structure of this project and had to redo the PR entirely, can you review it in #22?