Fix peer dependencies, fixes #11

rnc-archive / react-native-statusbar

Native module for mutating status bar state

MIT License

78 stars 14 forks source link

Closed MrLoh closed 5 years ago

cpojer commented 5 years ago

@dmtrKovalenko could you make a new release?

dmtrKovalenko commented 5 years ago

@cpojer I can, but I am not really sure that peer dependency react * is correct

dmtrKovalenko commented 5 years ago

And for me now everything seems to be working. Maybe because of yarn ?

cpojer commented 5 years ago

I'm unsure why it was working for you, but this PR is the right fix.

dmtrKovalenko commented 5 years ago

Anyway react: * is bad pattern.

dmtrKovalenko commented 5 years ago

If react will introduce any breaking change in example 17.0 - "Huston, we have a problem"

cpojer commented 5 years ago

I'm fine with changing it to ^16.0.