search

rnc-lbl / auau200GeVRun14

LBNL PicoDst HF Analysis Library (PicoHFLib) - Run14 Au+Au 200GeV
1 stars 15 forks source link

StPicoCutsBase::isGoodEvent default parameter value #84

Closed MustafaMustafa closed 9 years ago

MustafaMustafa commented 9 years ago

Hi Jochen,

The default parameter should be specified at declaration in the header file. https://github.com/rnc-lbl/auau200GeVRun14/blob/master/StRoot/StPicoCutsBase/StPicoCutsBase.cxx#L137

Using isGoodEvent without specifying aEventCuts result in a compilation error when default parameter is specified in the implementation file.

jthaeder commented 9 years ago

Indeed - I will fix it

On Jun 15, 2015, at 18:36, Mustafa Mustafa notifications@github.com wrote:

Hi Jochen,

The default parameter should be specified at declaration in the header file. https://github.com/rnc-lbl/auau200GeVRun14/blob/master/StRoot/StPicoCutsBase/StPicoCutsBase.cxx#L137 https://github.com/rnc-lbl/auau200GeVRun14/blob/master/StRoot/StPicoCutsBase/StPicoCutsBase.cxx#L137 Using isGoodEvent without specifying aEventCuts result in a compilation error when default parameter is specified in the implementation file.

— Reply to this email directly or view it on GitHub https://github.com/rnc-lbl/auau200GeVRun14/issues/84.

jthaeder commented 9 years ago

fixed in 15589b7