search

rncbc / padthv1

padthv1 - an old-school polyphonic additive synthesizer
https://padthv1.sourceforge.io
GNU General Public License v2.0
19 stars 7 forks source link

Pop audio cut whilst moving bars and playing. #12

Open thoth-amon opened 3 months ago

thoth-amon commented 3 months ago

Caused whilst using the bars to change the waveform and playing at the same time. When the mouse hold is lifted, there is a loud pop whilst the audio cuts. I have attached a recording of it.

padpop.zip

System Details: padthv1 verson 1.0 OpenSuse Tumbleweed (geekosdaw) Tested with the Standalone and LV2 in Carla and had the same issue.

rncbc commented 3 months ago

well yes, that's somehow expected behavior: editing the harmonics will regenerate a new brand wavetable, so probably all currently sounding voices, if any, will get abruptly cut off.

thoth-amon commented 3 months ago

The audio cutting out alone wouldn't be a problem if it didn't make the type of loud crack, which at high enough volume, can cause the audio server to die and/or possibly kill speakers.

rncbc commented 3 months ago

ok. please test whether ea8d6a5 (develop branch) is any better.

thanks

thoth-amon commented 3 months ago

It is better but still a problem. It's almost completely better when holding a note and then moving the bar/setting but if tapping on notes and moving settings it now varies from slightly to just as bad as before.

padclip.zip

rncbc commented 3 months ago

thanks; let me know whether ec06127 is an improvement...

unfortunately it won't get much better than this any time soon--changing most of the GEN PADsynth wavetable parameters are not realtime-smoothed anyway and probably never will; so sorry

thoth-amon commented 3 months ago

Still the same as before.

rncbc commented 3 months ago

last chance with 697ad93

nb. previous commits have been squashed; please reset to origin/develop.

thoth-amon commented 3 months ago

Not noticeably different again. Still much better than originally though.

I don't know whether this is of any use but I did notice now that when the high pass filter is set to 30, or higher, that removes any remaining popping sounds when changes are made.

rncbc commented 1 month ago

addressed and prolly solved by now >= v1.0.0.5git.1c5e17

please test && tell

thoth-amon commented 1 month ago

Yes, the pop effect has now gone. As you now have to wait for the previous note to finish, for sounds with long release this could feel like a change hasn't happened if you didn't know to wait. That's far less of a problem than the popping though IMHO