rncbc / qjackctl

QjackCtl - JACK Audio Connection Kit Qt GUI Interface
https://qjackctl.sourceforge.io
GNU General Public License v2.0
182 stars 40 forks source link

graph is blurry on high DPI macOS with Qt5 #170

Open Be-ing opened 2 years ago

Be-ing commented 2 years ago

Environment

Steps To Reproduce

Open QJackCtl distributed with JACK on macOS and click the Graph button

Expected vs. actual behavior

The connection graph in the QJackCtl build shipped with the macOS version of JACK does not scale well for high DPI screens. Everything within the graph is blurry but the text at the top of the window scales okay:

Screen Shot 2022-02-06 at 7 36 47 PM
rncbc commented 2 years ago

can't argue about macosx, but the Graph scales quite well and sharply on Linux X11/Wayland (Qt6.2)

Be-ing commented 2 years ago

This issue does not occur with QJackCtl from Homebrew which is built with Qt 6.2.2:

Screen Shot 2022-02-07 at 8 20 27 AM

I think this can be fixed by setting the Qt::AA_EnableHighDpiScaling when building with Qt5. This was removed in Qt6; high DPI scaling is always enabled in Qt6.

Be-ing commented 2 years ago

The graphics are still blurry because they're all low resolution rasters.

rncbc commented 2 years ago

I think this can be fixed by setting the Qt::AA_EnableHighDpiScaling when building with Qt5.

maybe you wanna have a look around here: https://github.com/rncbc/qjackctl/blob/e3c15c65c7628e13795d3eaff78a0de279737bc0/src/qjackctl.cpp#L557

Be-ing commented 2 years ago

Hmm, if that's already implemented then I'm nos sure what else could be the issue.

rncbc commented 2 years ago

issue (probably) lies on an old Qt5 perhaps?