rncbc / qjackctl

QjackCtl - JACK Audio Connection Kit Qt GUI Interface
https://qjackctl.sourceforge.io
GNU General Public License v2.0
182 stars 40 forks source link

Update French translation #195

Closed rdoursenaud closed 1 year ago

rdoursenaud commented 1 year ago

Also added non breakable spaces before double punctuation signs according to French typographic rules.

trebmuh commented 1 year ago

I'm unsure about the "non breakable spaces". I'll let Rui decide on those. Well..., I know about the French typographic rule, but am unsure about how this is handled while compiling. In qjackctl, I never ever saw a break space before a ponctuation sign making a ponctuation sign being alone on a line.

rdoursenaud commented 1 year ago

Thanks for your review. I've added my though process in the comments. Feel free to discuss.

rncbc commented 1 year ago

what's the matter about the "non breakable spaces" ? is that really necessary to a space (breakable or not) to precede a semi-colon? i guess it would make everybody happy if there was none, but that's probably just a non-French speaking here ;)

trebmuh commented 1 year ago

is that really necessary to a space (breakable or not) to precede a semi-colon?

In French, yes.

i guess it would make everybody happy if there was none, but that's probably just a non-French speaking here ;)

You're correct :)

rdoursenaud commented 1 year ago

what's the matter about the "non breakable spaces" ? is that really necessary to a space (breakable or not) to precede a semi-colon?

Yeah, it's a French typography rule. Every "double" punctuation signs (: ; ? !) shall be preceded by a non breaking space to avoid having the sign on its own on a new line when automatic formatting is used. We're also supposed to use them to separate thousands in big numbers, between date and/or hour members, before SI units and generally when we need to keep certain words or characters grouped. Since the character is relatively hard to access on our standard keyboard layout, many users omit them. This leads to ugly rendering in edge cases, so I'm trying my best to add them where appropriate. I don't see any downside to having them.

i guess it would make everybody happy if there was none, but that's probably just a non-French speaking here ;)

Probably but we don't make the rules ;)

rncbc commented 1 year ago

@trebmuh , @rdoursenaud : is it good to go now?

v0.9.11 is nigh ;)

trebmuh commented 1 year ago

With one more change to be reverted, it looks OK to me.

I've got one question that I don't have an answer and I'm relying on both of you for: let's take an example:

    <message>
        <source>Alt+A</source>
        <translatorcomment>Do not translate</translatorcomment>
        <translation></translation>
    </message>

What will be the outcome of this example:

rdoursenaud commented 1 year ago
  • will the French translation fallback to use "Alt+A" as well ?
  • or will the French translation use "nothing" because there is nothing between <translation> and </translation> and here is no "unfinished" tag?

It's exactly because this behavior is non-obvious that I made sure to fill every translation field even if the translation was identical to the "C" language string. I don't have the answer and can't test right now since I'm away from my Linux workstation and don't want to bother compiling under Windows.

Please let me know if I need to change anything.

rncbc commented 1 year ago
  • will the French translation fallback to use "Alt+A" as well ?

yes

  • or will the French translation use "nothing" because there is nothing between and and here is no "unfinished" tag?

no. but in doubt leave the "unfinished" there as it was.

rdoursenaud commented 1 year ago

no. but in doubt leave the "unfinished" there as it was.

This makes life harder as a translator :( I rely on this information to know which string has been updated and needs my attention. Plus similar untranslated strings weren't marked unfinished before.

rncbc commented 1 year ago

if you touched it, just leave as it was before

anyway you should pay attention to the: <translatorcomment>Do not translate</translatorcomment> and most importantly: please, do not remove any and never introduce new ones.

due to these problems, probably this PR won't make it to the v0.9.11 release, which is about to get tagged later today; sorry.