rncbc / qtractor

Qtractor - An Audio/MIDI multi-track sequencer
https://qtractor.org
GNU General Public License v2.0
499 stars 87 forks source link

Option to make copies of MIDI clips independent/unlinked by default #343

Open maxigaz opened 2 years ago

maxigaz commented 2 years ago

When a MIDI clip is copied, the new copy is linked with the original one. Before I start editing a copy, I manually unlink it more often than not, so having an option to make copies unlinked would be great.

I've read on linuxmusicians.com that somebody was going to create a feature request for this. I couldn't find the request or the option in Qtractor (or maybe I missed them), so here it is.

SyntacticalAnomaly commented 2 years ago

I'm not entirely sure how to request that this be assigned to me, but I think I'd like to take a crack at it

windowsrefund commented 2 years ago

This would be such a welcome feature as I'm constantly pressing "t", which I've bound to the unlink function, nearly every time immediately following a copy/paste.

rncbc commented 2 years ago

how would call or name this option? yeah, a concise text label is needed: eg. "Enable Auto Link"?, "Paste Special"?, whatever, please suggest (the whatever option is ON by default, as is now in practice)

and in what menu should it be placed: under Edit (which makes some sense, as it relates to copy/paste... ) or under Clip (which is about the same as the infamous "Unlink"?

the poll is now open:)

maxigaz commented 2 years ago

Clip > 'Autolink New Copies' sounds like a good option to me.

rncbc commented 2 years ago

Clip > 'Autolink New Copies' sounds like a good option to me.

sounds kinda "cheesy" to me XD

maxigaz commented 2 years ago

Clip > 'Autolink New Copies' sounds like a good option to me.

sounds kinda "cheesy" to me XD

I don't know what's 'cheesy' about it. Care to explain?

I was thinking from the point of view of a new user. To them, I think it's concise enough and straightforward.

In comparison, your suggestion 'Enable Auto Link' doesn't contain what it refers to exactly. Sure, it may be under the Clip menu, but autolink what clips, and for what purpose?

Anyway, this is just my opinion. :shrug:

windowsrefund commented 2 years ago

Clip > Linking: Auto | Manual

Additionally, I'd just suggest there be a way to always ensure a copied clip is linked by way of something like holding CTRL when pasting. Some sane "override" may already be in place but I'm on the other side of my KVM at the moment and can't check.

maxigaz commented 2 years ago

Additionally, I'd just suggest there be a way to always ensure a copied clip is linked by way of something like holding CTRL when pasting.

Another idea: Ctrl acts as a temporary toggle. So, if autolink is disabled and you Ctrl+drag a clip, the new copy will be linked and vice versa.

Some sane "override" may already be in place but I'm on the other side of my KVM at the moment and can't check.

I don't notice any difference when I press Ctrl+v and then click while holding Ctrl/Alt/Shift.

rncbc commented 2 years ago

Clip > Linking: Auto | Manual

Additionally, I'd just suggest there be a way to always ensure a copied clip is linked by way of something like holding CTRL when pasting. Some sane "override" may already be in place but I'm on the other side of my KVM at the moment and can't check.

No there isn't one, but I find this idea the most feasible in the short term: however, to keep current behavior as is, Ctrl+click/enter should hint to Unlink the pasted clips (or not to link them automatically as usual).

rncbc commented 2 years ago

there's one caveat to all this auto-unlink operation though: cloned MIDI files will start to proliferate and piling up in the file-system (on disk) quite easily...

is that really what you're asking for?

that said, I'd really prefer the Ctrl+click/Enter discrete option and only; so a global option won't probably get any favor from here.

windowsrefund commented 2 years ago

Personally, I'd never be concerned about the underlying MIDI files because well, that's just the cost of doing business. If I have 2 unique MIDI clips/regions on a track, it's reasonable to expect that data is represented somewhere on disk. Since that is true for 2, it has to be true for hundreds or thousands.

rncbc commented 2 years ago

already said Ctrl+click/Enter is one good idea, if not the best, I think both of you @windowsrefund and @maxigaz are in

what's the trouble?

windowsrefund commented 2 years ago

Sorry, what exactly is the question?

rncbc commented 2 years ago

@windowsrefund: the question follows from your suggestion:

Additionally, I'd just suggest there be a way to always ensure a copied clip is linked by way of something like holding CTRL when pasting.

and also from @maxigaz follow-up:

Another idea: Ctrl acts as a temporary toggle. So, if autolink is disabled and you Ctrl+drag a clip, the new copy will be linked and vice versa.

thank you both

rncbc commented 2 years ago

Ctrl+click/enter to auto-unlink any pasted clips are now in: please test with >= 0.9.26.34git.676c3f

maxigaz commented 2 years ago

It works. Thank you!

@rncbc You mentioned this in an earlier comment:

I'd really prefer the Ctrl+click/Enter discrete option and only; so a global option won't probably get any favor from here.

Can I still leave this issue open in case @SyntacticalAnomaly or someone else want to implement it as a global option?

windowsrefund commented 2 years ago

Thank you rncbc. Still a fan of the default behavior being specified by the user and the key acting as an opposing override. That said, this is a solid move in terms of usability. Thanks again.

windowsrefund commented 6 months ago

Wow, just rediscovered this added capability (skip the autolinking when holding CTRL when copying a clip). It's like finding a $20 :)