search

rncbc / qtractor

Qtractor - An Audio/MIDI multi-track sequencer
https://qtractor.org
GNU General Public License v2.0
495 stars 86 forks source link

Note off messages not sent while playing after loop region #359

Open nikolay-t opened 1 year ago

nikolay-t commented 1 year ago

Built from sources, at commit ID 40306ee60e243 (tag: qtractor_0_9_28). Issue is that note off messages are not sent (to instruments) while playing after loop region - when loop is enabled.

To reproduce:

  1. Have track with MIDI notes.
  2. Select short region in the middle as loop, enable loop (important)
  3. Place play-head after end of loop
  4. Start playback
  5. See that Note off MIDI messages are not sent, resulting in a wrong sounds

Expectation: regardless of loop enabled or disabled, Note off messages should be sent in any place of track (before and after the loop).

rncbc commented 1 year ago

confirmed. fixed in https://github.com/rncbc/qtractor/commit/90f75b6

thanks