MIDI off is not sent on transport stop

[TatriX]

Hi again! I'm sending midi notes to the external device. When I stop the transport in the middle of a note, no note off message seems to be send to the device resulting in a hanging note.

Here's what midi traces on the device shows:

You can notice that A2# note on was sent, but no corresponding note off event was sent when I pressed spacebar.

[rncbc]

correct; an all notes off is (CC#123) sent instead; the device should shut off all playing in that channel in response; note-off messages are not sent when playback stops whatsoever.

[TatriX]

Unfortunately hardware I have for whatever reason ignores all-notes-off. I don't know if it's on purpose or not. What I know is that my sequencer is sending individual note-off events when I press stop. Maybe it's doing that to overcome the all-note-off quirks or the sequencer itself it to blame. This is quite an issue for me, because I have to trigger midi-panic almost every time I stop the transport.

[TatriX]

Just checked Bitwig: it sends individual note-off events on transport stop.

[rncbc]

qtractor doesn't and that's a fact for over more than 15 years now.

[TatriX]

I assume that means WONTFIX. Fair enough. Thank you for your time!

[rncbc]

you may now test this feature from the new xnoteoffs branch

[TatriX]

Oh, that's amazing, thank you! Just gave it a shot - it does work! One issue I've found is that if you stop the transport after the loop wraps, noteoffs are not sent.

[rncbc]

One issue I've found is that if you stop the transport after the loop wraps, noteoffs are not sent.

yes, that has been addressed just a few moments ago in https://github.com/rncbc/qtractor/commit/161a4b4

EDIT: make it from https://github.com/rncbc/qtractor/commit/2d4144f instead, please

thanks

[TatriX]

Works like a charm, thank you!

[rncbc]

merged/squashed into develop and master (qtractor >= 0.9.33.3); branch xnoteoffs deleted.