search

rncbc / qtractor

Qtractor - An Audio/MIDI multi-track sequencer
https://qtractor.org
GNU General Public License v2.0
510 stars 89 forks source link

CLAP: implement request_callback for Qt 5.0+ #404

Closed ahigerd closed 1 year ago

ahigerd commented 1 year ago

The previous PR used a technique introduced in Qt 5.10, but since @rncbc wants to support Qt 5.9, this one works in 5.4 and higher. (I think I might like it slightly better anyway.)

ahigerd commented 1 year ago

Oh. Crap. Turns out this doesn't work after all -- my plugin was triggering this on the main thread already by mistake.

ahigerd commented 1 year ago

Okay, used a Qt 5.0+-compatible technique instead.

rncbc commented 1 year ago

oh please don't ... I believe it's pretty awesome as is now; old systems that still hang on qt5 < 5.10 may not cope to clap plugins anyway, so why bother?

i'll take back my pledge for you do try it, sorry, it was some kind of knee-jerk reaction somehow :)

ahigerd commented 1 year ago

I already updated this PR to fix it! You can reject it if the technique is too ugly for you, but it works.

ahigerd commented 1 year ago

Okay, it's too ugly. :P