search

rncbc / qtractor

Qtractor - An Audio/MIDI multi-track sequencer
https://qtractor.org
GNU General Public License v2.0
514 stars 90 forks source link

The new backwards step action goes to before 0, and then jumps to bar 62414. #437

Closed toadzroc closed 9 months ago

toadzroc commented 10 months ago

The new step forward and step backward actions work ok with two caveats., and I put them both in here as they are related.

  1. When the step backwards action is used, and the playback cursor goes to before 0 in the timeline, it jumps to bar 62414. Using the fast rewind action restores the position of the PB cursor to the beginning of the project, and stops there, and it cannot go any further, i.e. before zero. (bar 1) I suggest the same barrier be added to the step backwards action.

  2. When any tempo or time signature change is added to the timeline, the step actions become less stable and keep jumping at random to that magic bar number 62414, whether it's the forward or reverse action, and most often occurs when the action is held down. Again, the fast rewind action is pressed, the PB cursor returns to its original position.

rncbc commented 10 months ago
  1. maybe fixed in 172b2be
  2. WIP

thanks

toadzroc commented 10 months ago

Halfway there. The actions don't jump anymore when there's no changes in the timeline.

When there are changes in the timeline, the problem persists.

Making progress.

rncbc commented 10 months ago
  1. and 2. both fixed in 706896d

hopefully

toadzroc commented 10 months ago

Rui, almost there. I don't see bar 62414 anymore, but when a change of tempo is added to the timeline, the step backward action stops just before the added tempo entry.

Using the rewind action releases the PB cursor to the start.

qtractor-actions-1

rncbc commented 10 months ago

can you tell a minimal set of steps where and when the said bug ("step backward stops just before the added tempo entry") is showing?

i kinda fail to reproduce this happening

toadzroc commented 10 months ago

I've made a really rough video of what's happening. Note the tempo change at bar 4, and the tempo change at bar 5. The cursor will not go any further back along the timeline, with the step actions.

https://github.com/rncbc/qtractor/assets/101512759/66ea9d84-d300-4726-a733-f3c8e0d3f244

rncbc commented 10 months ago

thanks, maybe a 3rd time is final one: a252bf9 :)

toadzroc commented 10 months ago

Yep, it's working now. Many thanks.

I'll let you know if something else comes up. :)